Use user from request context #759

prudloff-insite · 2023-11-21T09:50:11Z

This fixes #758 for us but it might not be the correct solution.

I find it a bit strange that Parser::getUserIdentity() does not check if Parser::getOptions() returns null before trying to use its result. (The documentation of Parser::getOptions() acknowledges that it can return null.)

JeroenDeDauw · 2023-11-21T13:20:02Z

I'm not sure either that your change is correct. It seems safer to get the user from the Parser object rather than via a global.

freephile

Could we check for null ParserOptions like so:

!is_null($this->parser::getOptions()) ?? new ParserOptions($this->parser->getUserIdentity()) : null;

Use user from request context

4d50c26

freephile reviewed Nov 27, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use user from request context #759

Use user from request context #759

prudloff-insite commented Nov 21, 2023

JeroenDeDauw commented Nov 21, 2023

freephile left a comment •

edited

Loading

Use user from request context #759

Are you sure you want to change the base?

Use user from request context #759

Conversation

prudloff-insite commented Nov 21, 2023

JeroenDeDauw commented Nov 21, 2023

freephile left a comment • edited Loading

Choose a reason for hiding this comment

freephile left a comment •

edited

Loading